Hello
In the concept table, apparently there is no specific “concept type” for visit_detail. There is only the one dedidated for visit_occurrence (see in athena)
Then, the implementation problem is that both visit_occurrence and visit_detail share the same codes. This is an issue for multiple reason:
- same information can be repeated in both tables
- ETLers might be confused on where information should go
- this is orthogonal to the CDM overall architecture (that tends to point a domain only one table)
- concepts behind columns in each table essencially overlap (eg: visit_type_id and visit_detail_type_id are from the same set of concept_id)
- this limits the information that can be stored in the CDM (types of visit should not be the same in occurrence or detail)
Is there a on going proposal for visit_detail dedicated domain_id ? I d be glad to make a proposal on that point.
(same topic on github)