OHDSI Home | Forums | Wiki | Github

SQL Server data types

We’re preparing to instantiate an OMOP CDM v5.3.1 on SQL Server and load it from our Epic Caboodle database. I want to ensure we’re getting off on the right foot, especially in regards to “future proofing”. I have some SQL Server data type questions that are probably best posed to @clairblacketer, @Christian_Reich, and @Patrick_Ryan as the authors of the SQL Server DDL.

  1. Why VARCHAR(1) for Boolean flags instead of TINYINT or even CHAR(1)? (I can understand hesitancy over using SQL Server’s BIT data type.)
  2. Did OHDSI make a conscious choice to use VARCHAR instead of NVARCHAR? (Epic uses NVARCHAR in Caboodle.)
  3. Why FLOAT in the COST table instead of NUMERIC? Any concerns with aggregating monetary amounts?
  4. Why FLOAT in the LOCATION table instead of NUMERIC(10,8) for latitude (+/-90 degrees) and NUMERIC(11,8) for longitude (+/-180 degrees)?
  5. I imagine there is no harm in future proofing our CDM v5.3.1 by using BIGINT now for the non-concept ID primary keys?
  6. Confirm that we are free to increase the length of any VARCHAR column, if we need to do so?

Like many academic organizations, we will use our OMOP instance both for our internal researchers and for contributing data to various research networks. I do not want to make any technical decisions that would get us into trouble later for either of these use cases. Thanks so much!

2 Likes

Hi Tim,

Did you find answers to these questions? I am just starting out implementing CDM 5.4 and am running into issues on Sql Server as well.

-Sanjay

Hello @Sanjay_Udoshi,

As you can see from this thread, no one replied to my original post.

We elected to make “compatible” data type changes and have experienced no problems sharing OMOP data extracts with research partners & collaboratives.

By “compatible”, I mean that the data type can be converted implicitly without throwing an error.

  • INTEGER to BIGINT – for all id columns (but not the concept_id columns)
  • INTEGER to SMALLINT or TINYINT – for columns like person.year_of_birth and person.day_of_birth
  • VARCHAR to NVARCHAR
  • VARCHAR(1) to NCHAR(1) – because there is no need to use 2 extra bytes to store a trivial length
  • FLOAT to NUMERIC(p,s)
  • DATETIME to DATETIME2 – per Microsoft’s recommendation and for ANSI / ISO 8601 compliance
  • Lengthen (N)VARCHAR columns as needed to match the length of our source system’s columns

Thank you @quinnt !
This is very helpful.

One other point that I found is to make the collation = SQL_Latin1_General_CP1_CS_AS for the underlying SQL Server database. This caused problems when I started out with the default as SQL_Latin1_General_CP1_CI_AS

-Sanjay

The changes you have identified will not create any problems in creating your ETL and should not be a problem when running the Data Quality Dashboard, Achilles or Atlas. But you will be the ones testing these changes, so please update this post as you start running the QC and analytic programs.

1 Like

I can confirm that the data type changes I enumerated above have not caused us any problems over the past 2 years with the OHDSI tools that @DTorok mentioned:

  • ATLAS
  • ACHILLES (including HEEL)
  • Data Quality Dashboard (DQD)

For the record, we’re using Microsoft SQL Server 2019 Enterprise Edition (version 15.0.4153.1).

2 Likes

Tim,

Are you using the Broadsea containers for general use? How many users do you have?

-Sanjay

t