OHDSI Home | Forums | Wiki | Github

Atlas repository contains only minified js code

We’re looking to skin atlas with our own styles, but after checking out from GitHub it appears that the project contains minified versions of the main js files. This is akin to checking in compiled code but not the sources. Are there any plans for a more complete, build-from-source project in GitHub?

Hi, @malcolmm83.

Nothing (except 3rd party libs that we’ve loaded into our own repository) is minified. main.js and app.js and pretty much all the other modules are not minified. We’d like to look into a build process that would build all the separate module files into a single bundle (to improve loading times) but for now we’re just telling people to install atlas by installing the git repo under a web root and editing the config.js to point to the proper WebAPI.

We’re looking for people with experience with minification of JS libraries using things like r.js (require JS’s optimizer). If this is something you’d like to help out with, that’d be awesome.

-Chris

If we’re going to start having any kind of build process, I think we ought to also change all the third party libraries to npm package dependencies. I’m not sure the best way to have require.js work with npm packages in node_modules, but it’s not hard. My preference for building code bundles has been webpack in recent years. Of course, webpack can also manage requiring dependencies, making requirejs unnecessary. I don’t know if we want to go down that route, but should at least consider it before increasing our investment in require.js by using r.js. (Maybe start thinking about it by looking at some of this.)

t