OHDSI Home | Forums | Wiki | Github

Missing sql export from cohort definition

Researchers
,
#21

I’ve created a PR in the past week to address the issue where there was a race-condition around loading Prism (the utility that formats sql). You can find it here.

If you are able, you could pull that branch and deploy it to your test environment and try. I’m sorry, I can’t commit to doing a in person diagnosis, and I apologize if that is frustrating, but the PR above (and branch) should handle the situation where sometimes it works and sometimes it does not due to a loading order of the javascript.

It would be helpful to me if you tried this because then that would give further confidence in the PR to fix the issue.

#22

How do I do this ?
I am new to R, etc. Is there a package to load ?

#23

Not an R thing, just a GIT thing:

git fetch
git checkout issue-2876

That will set your atlas directory to that branch. Just proceed as if you were working off of the 2.13 version.

#24

I ran git fetch; git checkout issue-2876 in e:\git\OHDSI\atlas; and now it seems we are building atlas@2.14.0-DEV . Is that to be expected ? We had been working on 2.13.0 .

#25

Yes, it’s expected because this issue is a fix for the next release (2.14). I was hoping you could try that branch in a test environment to see if you get improved results, but then you can go back to 2.13 (but it will have that problem with inconsistent error).

To go back:

git checkout v2.13.0
#26

Better idea: I cherry-picked my fix from master onto the v2.13.0 release tag, and now you can do this:

git fetch
git checkout v2.13.0-issue-2876

Here, the branch name is v2.13.0-issue-2876, which should show as v2.13.0 in atlas, but will have the change to address the loading issue. Give that a try.

Update: I pushed a change to package.json so that the version should show up as v2.13.1-DEV, hopefully that will give you the indication that your code is updated.

#27

Chris,
This seems to work fine.
We will run it in Stage/Test environment for awhile, before promoting (installing) in Production.
–Lyndon

t